Skip to content

Fix symbol-publish gate in build-all-lib.yml to use a branch allowlist #4960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Denis Voituron (dvoituron) merged 2 commits into from
Jun 24, 2026
Merged

Fix symbol-publish gate in build-all-lib.yml to use a branch allowlist #4960

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a29a55a
Fix symbol-publish gate in build-all-lib.yml to branch allowlist
tlmii Jun 24, 2026
2872cf0
Clarify symbol-publish comment in build-all-lib.yml
tlmii Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions eng/pipelines/build-all-lib.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,12 @@ extends:

# Stage shipping binaries for symbol upload BEFORE the test step;
# see publish-symbols-stage.yml for why this must run pre-test.
# Pipeline only triggers on v* tags, but condition is explicit so
# a manual queue against a branch does not unintentionally upload.
# Releases are cut by manually queueing this pipeline against a release
# branch HEAD, so gate on the branch allowlist (consistent with
# build-core-lib.yml); the tag check covers the declared trigger.
- template: /eng/pipelines/publish-symbols-stage.yml@self
parameters:
condition: and(succeeded(), startsWith(variables['Build.SourceBranch'], 'refs/tags/v'))
condition: and(succeeded(), or(in(variables['Build.SourceBranch'], 'refs/heads/main', 'refs/heads/dev', 'refs/heads/dev-v5'), startsWith(variables['Build.SourceBranch'], 'refs/heads/archives/'), startsWith(variables['Build.SourceBranch'], 'refs/tags/v')))

# Test and generate Code Coverage
- task: DotNetCoreCLI@2
Expand Down Expand Up @@ -225,7 +226,7 @@ extends:

- template: /eng/pipelines/publish-symbols-upload.yml@self
parameters:
condition: and(succeeded(), startsWith(variables['Build.SourceBranch'], 'refs/tags/v'))
condition: and(succeeded(), or(in(variables['Build.SourceBranch'], 'refs/heads/main', 'refs/heads/dev', 'refs/heads/dev-v5'), startsWith(variables['Build.SourceBranch'], 'refs/heads/archives/'), startsWith(variables['Build.SourceBranch'], 'refs/tags/v')))

# Since NuGet packages are generated during the build, we need to copy them to the artifacts folder.
- task: CopyFiles@2
Expand Down
Loading