Skip to content

fix: rename custom events whose name matches browserEventName to avoid .NET 11 exception #4607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vnbaaij merged 8 commits into from
Mar 9, 2026
Merged

fix: rename custom events whose name matches browserEventName to avoid .NET 11 exception #4607

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d830004
Initial plan
Copilot Mar 8, 2026
9dabb31
fix: rename custom events with same name as browserEventName to avoid…
Copilot Mar 8, 2026
5d51f93
chore: remove accidentally committed build artifact and update .gitig…
Copilot Mar 8, 2026
3f3d37f
fix: rename custom events to listchange/textimmediate and revert .git…
Copilot Mar 8, 2026
a8d7d1a
chore: add Core.Scripts/.gitignore and remove committed build artifact
Copilot Mar 8, 2026
88499ea
chore: update Core.Scripts/.gitignore and remove committed build arti…
Copilot Mar 8, 2026
0e78cae
chore: remove build artifact with backslash path from git tracking
Copilot Mar 8, 2026
fd5e1de
chore: revert package-lock.json and remove Core.Scripts/.gitignore
Copilot Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ bld/
[Ll]og/
[Ll]ogs/
[Dd]ist/
src/Core.Scripts/obj*
Comment thread
vnbaaij marked this conversation as resolved.
Outdated

# Visual Studio 2015/2017 cache/options directory
.vs/
Expand Down
4 changes: 2 additions & 2 deletions src/Core.Scripts/src/FluentUICustomEvents.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export namespace Microsoft.FluentUI.Blazor.FluentUICustomEvents {
}
});

blazor.registerCustomEventType('listboxchange', {
blazor.registerCustomEventType('fluentlistboxchange', {
Comment thread
vnbaaij marked this conversation as resolved.
Outdated
browserEventName: 'listboxchange',
createEventArgs: (event: any)=> {
return {
Expand Down Expand Up @@ -155,7 +155,7 @@ export namespace Microsoft.FluentUI.Blazor.FluentUICustomEvents {
}

export function TextInput(blazor: Blazor) {
blazor.registerCustomEventType('immediate', {
blazor.registerCustomEventType('fluentimmediate', {
Comment thread
vnbaaij marked this conversation as resolved.
Outdated
browserEventName: 'immediate',
createEventArgs: (event: any)=> {
return {
Expand Down
2 changes: 1 addition & 1 deletion src/Core/Components/List/FluentListbox.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
name="@Name"
readonly="@ReadOnly"
required="@Required"
@onlistboxchange="@OnDropdownChangeHandlerAsync"
@onfluentlistboxchange="@OnDropdownChangeHandlerAsync"
@onfocusout="@FocusOutHandlerAsync"
@attributes="@AdditionalAttributes">
<fluent-listbox style="@ListStyle">
Expand Down
2 changes: 1 addition & 1 deletion src/Core/Components/TextArea/FluentTextArea.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
value="@CurrentValueAsString"
@onfocusout="@FocusOutHandlerAsync"
@onchange="@ChangeHandlerAsync"
@onimmediate="@InputHandlerAsync"
@onfluentimmediate="@InputHandlerAsync"
@attributes="AdditionalAttributes">
</fluent-textarea>
</FluentField>
2 changes: 1 addition & 1 deletion src/Core/Components/TextInput/FluentTextInput.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
value="@CurrentValueAsString"
@onfocusout="@FocusOutHandlerAsync"
@onchange="@ChangeHandlerAsync"
@onimmediate="@InputHandlerAsync"
@onfluentimmediate="@InputHandlerAsync"
@attributes="AdditionalAttributes">

@if (StartTemplate != null)
Expand Down
4 changes: 2 additions & 2 deletions src/Core/Events/EventHandlers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@ namespace Microsoft.FluentUI.AspNetCore.Components;
[EventHandler("onmenuitemchange", typeof(MenuItemEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("ontabchange", typeof(TabChangeEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("ondropdownchange", typeof(DropdownEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("onlistboxchange", typeof(DropdownEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("onfluentlistboxchange", typeof(DropdownEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("ontreechanged", typeof(TreeItemChangedEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("ontreetoggle", typeof(TreeItemToggleEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("onclosecolumnoptions", typeof(EventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("onclosecolumnresize", typeof(EventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("onradiochange", typeof(RadioEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("onimmediate", typeof(ChangeEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
[EventHandler("onfluentimmediate", typeof(ChangeEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
public static class EventHandlers
{
}
2 changes: 1 addition & 1 deletion tests/Core/Components/TextArea/FluentTextAreaTests.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@
var cut = Render(@<FluentTextArea @bind-Value="@value" Immediate="@immediate" ImmediateDelay="@immediateDelay" />);

// Act
cut.Find("fluent-textarea").TriggerEvent("onimmediate", new ChangeEventArgs() { Value = "new value"});
cut.Find("fluent-textarea").TriggerEvent("onfluentimmediate", new ChangeEventArgs() { Value = "new value"});

// Assert: Immediate
Assert.Equal(expectedImmediateValue, value);
Expand Down
2 changes: 1 addition & 1 deletion tests/Core/Components/TextInput/FluentTextInputTests.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@
var cut = Render(@<FluentTextInput @bind-Value="@value" Immediate="@immediate" ImmediateDelay="@immediateDelay" />);

// Act
cut.Find("fluent-text-input").TriggerEvent("onimmediate", new ChangeEventArgs() { Value = "new value"});
cut.Find("fluent-text-input").TriggerEvent("onfluentimmediate", new ChangeEventArgs() { Value = "new value"});

// Assert: Immediate
Assert.Equal(expectedImmediateValue, value);
Expand Down
Loading