Skip to content

[DataGrid] Fix resize indicator height (when ResizeColumnOnAllRows is true) #4383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dvoituron merged 7 commits into from
Dec 9, 2025
Merged

[DataGrid] Fix resize indicator height (when ResizeColumnOnAllRows is true) #4383

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c034a53
Fix #4378 by removing default header padding
vnbaaij Dec 5, 2025
f43bd0a
Update src/Core/Components/DataGrid/FluentDataGrid.razor
vnbaaij Dec 5, 2025
24f3a6d
Update veriefied files
vnbaaij Dec 8, 2025
ccfe6e5
Merge branch 'users/vnbaaij/fix-issue-#4378' of https://github.com/mi…
vnbaaij Dec 8, 2025
85044b0
Merge branch 'dev' into users/vnbaaij/fix-issue-#4378
vnbaaij Dec 8, 2025
7bdcdac
Fix comment
vnbaaij Dec 8, 2025
e01af32
Merge branch 'users/vnbaaij/fix-issue-#4378' of https://github.com/mi…
vnbaaij Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Core/Components/DataGrid/FluentDataGrid.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,8 @@

@if (ResizableColumns)
{
<div class="resize-handle"></div>
var top = DisplayMode == DataGridDisplayMode.Table ? "top: 4px;" : "top: 2px;";
Comment thread
vnbaaij marked this conversation as resolved.
Outdated
<div class="resize-handle" style="@top"></div>
}
</FluentDataGridCell>
}
Expand Down
1 change: 0 additions & 1 deletion src/Core/Components/DataGrid/FluentDataGrid.razor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@

::deep .resize-handle {
position: absolute;
top: 5px;
right: 0;
left: unset;
bottom: 0;
Expand Down
13 changes: 8 additions & 5 deletions src/Core/Components/DataGrid/FluentDataGrid.razor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ export function enableColumnResizing(gridElement, resizeColumnOnAllRows = true)
if (!resizeColumnOnAllRows) {
// Only use the header height when resizeColumnOnAllRows is false
// Use the first header's height if available
resizeHandleHeight = headers.length > 0 ? (headers[0].offsetHeight - 14 ): 30; // fallback to 30px if no headers
resizeHandleHeight = headers.length > 0 ? (headers[0].offsetHeight - 14 ): 32; // fallback to 30px if no headers
Comment thread
vnbaaij marked this conversation as resolved.
Outdated
Comment thread
vnbaaij marked this conversation as resolved.
Outdated
}

headers.forEach((header) => {
Expand All @@ -201,8 +201,11 @@ export function enableColumnResizing(gridElement, resizeColumnOnAllRows = true)
const resizedivs = header.querySelectorAll(".actual-resize-handle");
resizedivs.forEach(div => div.remove());

// Get the top of the first resize-handle
const resizeTop = header.querySelector('.resize-handle').offsetTop;
Comment thread
vnbaaij marked this conversation as resolved.

// add a new resize div
const div = createDiv(resizeHandleHeight, isRTL);
const div = createDiv(resizeHandleHeight, resizeTop, isRTL);
header.appendChild(div);
setListeners(div, isRTL);
});
Expand Down Expand Up @@ -283,14 +286,14 @@ export function enableColumnResizing(gridElement, resizeColumnOnAllRows = true)
});
}

function createDiv(height, isRTL) {
function createDiv(height, top, isRTL) {
const div = document.createElement('div');
div.className = "actual-resize-handle";
div.style.top = '5px';
div.style.top = top + 'px';
div.style.position = 'absolute';
div.style.cursor = 'col-resize';
div.style.userSelect = 'none';
div.style.height = (height - 5) + 'px';
div.style.height = (height - 4) + 'px';
Comment thread
vnbaaij marked this conversation as resolved.
div.style.width = '6px';
div.style.opacity = 'var(--fluent-data-grid-header-opacity)'

Expand Down
2 changes: 1 addition & 1 deletion src/Core/Components/DataGrid/FluentDataGridCell.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public partial class FluentDataGridCell<TGridItem> : FluentComponentBase
.AddStyle("height", $"{Grid.ItemSize:0}px", () => !Grid.EffectiveLoadingValue && Grid.Virtualize)
.AddStyle("height", $"{(int)Grid.RowSize}px", () => !Grid.EffectiveLoadingValue && !Grid.Virtualize && !Grid.MultiLine && (Grid.Items is not null || Grid.ItemsProvider is not null) && InternalGridContext.TotalItemCount > 0)
.AddStyle("height", "100%", Grid.MultiLine)
.AddStyle("min-height", "44px", Owner.RowType != DataGridRowType.Default)
.AddStyle("min-height", "40px", Owner.RowType != DataGridRowType.Default)
.AddStyle("z-index", ZIndex.DataGridHeaderPopup.ToString(), CellType == DataGridCellType.ColumnHeader && Grid._columns.Count > 0 && Grid.UseMenuService)
.AddStyle(Owner.Style)
.Build();
Expand Down
1 change: 0 additions & 1 deletion src/Core/Components/DataGrid/FluentDataGridCell.razor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ td.grid-cell-placeholder:after {
font-weight: 600;
text-align: center;
position: relative;
padding: calc((var(--design-unit) + var(--focus-stroke-width) - var(--stroke-width)) * 1px) 1px calc((var(--design-unit) + var(--focus-stroke-width) - var(--stroke-width)) * 1px);
}

::deep .col-sort-button {
Expand Down
Loading