Skip to content

Update the 'IDialogService.CloseAsync' methods to accept an IDialogReference interface instead of the concrete DialogReference class. #4316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2025
Merged

Update the 'IDialogService.CloseAsync' methods to accept an IDialogReference interface instead of the concrete DialogReference class. #4316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31fc560
Update the 'IDialogService.CloseAsync' methods to accept an IDialogRe…
StevenRasmussen Nov 12, 2025
14ab8f6
Merge branch 'dev' into dialog-reference-fix
vnbaaij Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Core/Components/Dialog/Services/DialogService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
// This file is licensed to you under the MIT License.
// ------------------------------------------------------------------------

using System.Diagnostics.CodeAnalysis;
using Microsoft.AspNetCore.Components;
using System.Diagnostics.CodeAnalysis;

namespace Microsoft.FluentUI.AspNetCore.Components;

Expand All @@ -30,12 +30,12 @@ public DialogService()
/// <returns></returns>
public EventCallback<DialogResult> CreateDialogCallback(object receiver, Func<DialogResult, Task> callback) => EventCallback.Factory.Create(receiver, callback);

public Task CloseAsync(DialogReference dialog)
public Task CloseAsync(IDialogReference dialog)
{
return CloseAsync(dialog, DialogResult.Ok<object?>(null));
}

public Task CloseAsync(DialogReference dialog, DialogResult result)
public Task CloseAsync(IDialogReference dialog, DialogResult result)
{
OnDialogCloseRequested?.Invoke(dialog, result);
return Task.CompletedTask;
Expand Down
4 changes: 2 additions & 2 deletions src/Core/Components/Dialog/Services/IDialogService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ namespace Microsoft.FluentUI.AspNetCore.Components;

public partial interface IDialogService
{
Task CloseAsync(DialogReference dialog);
Task CloseAsync(IDialogReference dialog);

Task CloseAsync(DialogReference dialog, DialogResult result);
Task CloseAsync(IDialogReference dialog, DialogResult result);

/// <summary>
/// An event that will be invoked when showing a dialog with a custom component
Expand Down
Loading