-
Notifications
You must be signed in to change notification settings - Fork 459
[Toast] Add DynamicDependency to prevent trimming errors #3994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 60.5%
|
dvoituron
approved these changes
Jul 9, 2025
This was referenced Jul 22, 2025
This was referenced Jul 30, 2025
Closed
This was referenced Oct 13, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to enhance compatibility with trimming tools by adding
DynamicDependencyattributes to several toast components. These changes ensure that the public constructors of the components are preserved during trimming.Enhancements for trimming compatibility:
src/Core/Components/Toast/ContentComponents/CommunicationToast.razor.cs: Added a[DynamicDependency]attribute to preserve public constructors of theCommunicationToastclass during trimming.src/Core/Components/Toast/ContentComponents/ConfirmationToast.razor.cs: Introduced a newConfirmationToastclass with a[DynamicDependency]attribute to ensure public constructors are retained.src/Core/Components/Toast/ContentComponents/ProgressToast.razor.cs: Added a[DynamicDependency]attribute to theProgressToastclass to preserve its public constructors during trimming.Fix #3973