Skip to content

Conversation

@MarvinKlein1508
Copy link
Collaborator

Pull Request

📖 Description

This PR changes the CSS variable which is being used to set the text color for the placeholder in FluentSelect.

Every other input uses --input-placeholder-rest for the text color. FluentSelect has been using --neutral-base-color before which has a slight darker gray tone.

Before:
dialog-before

After:
dialog-after

👩‍💻 Reviewer Notes

I have updated the FluentSelectTests.FluentSelect_Placeholder.verified.razor.html unit test to reflect this change.

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • [] I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants