-
Notifications
You must be signed in to change notification settings - Fork 459
[DataGrid] Use ColumnOptonsLabels.Icon in more places #3865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ault remains unchanged
dvoituron
approved these changes
Jun 3, 2025
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 60.3%
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already had the functionality in place to specify custom labels and icons for sorting and filtering. But these were only being applied if the
HeaderCallAsButtonWithMenuparameter is set to true. With this PR the filter icon can now also be changed when theHeaderCallAsButtonWithMenuparameter is set to false.Also, with this PR an inconsistency in the icon being displayed when a filter is applied has been corrected. Previously, when a filter was applied, the
FilterDismissicon was being displayed. But clicking the button did not actually remove the filter. Now, the same icon will be displayed regardless of a filter being applied or not. The chosen filter icon will be displayed after the title (just like the sort arrows) in the column header to indicate a filter has been applied.Before:
After:
In this case a custom icon is being used for the filtering indicator like this:
Fix #3846