[MainLayout] Remove double header reduction #3841
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3836
Pull Request
📖 Description
Removed header height reductions from
Mainlayout, added a vertical stack.Stacks now always have 100% height.
I've kept the
--header-heightvariable as it might be used by some users already.🎫 Issues
#3836
👩💻 Reviewer Notes
I think we should take cases in consideration when the navigation or main content exceeds the 100%.
We can either re-add the subtraction to the vertical stack and add a parameter to the component
SubHeaderHeightand subtract this from the horizontal stack.Or we can let the user define the styles for these stacks themselves.
📑 Test Plan
Added test to check default styles of mainlayout stacks
✅ Checklist
General
Component-specific