-
Notifications
You must be signed in to change notification settings - Fork 459
[DesignTokens] Make AccentBaseColor and NeutralBaseColor work with WithDefault
#3517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix analyzer comment
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 59.7%
|
dvoituron
approved these changes
Mar 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3511, Fix #2158
Both
AccentBaseColorandNeutralBaseColorrequire some special handling to make it possible to assign a new color value with theWithDefaultmethod. This PR adds that.So by using the following code:
You will now see the correct value outputted for the
--accent-base-colorand--neutral-base-colorCSS variables:and
This means now all related accent buttons, checkboxes, etc. and layers and other neutral components will use the correct colors as well (calculated with a recipe defined by the web components script).
Using the values provided above will give you this (horrendous) result:
Light mode:

DarkMode:

NOTE If you are using the
FluentDesignThemecomponent, theAccentBaseColorwill be reset to whatever primary color value you have specified there.