-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Icons] Update to Fluent UI System Icons 1.1.266 #2990
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create project for each variant, change core Icon project ot reference new projects
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 59.7%
|
…m/microsoft/fluentui-blazor into users/vnbaaij/icons-build-changes
- Adjust `RootNamespace`s
dvoituron
requested changes
Dec 2, 2024
dvoituron
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Icons Emojis] Split to multiple DLLs in a single NuGet package
Update to Fluent UI System Icons 1.1.266
We were running into the following error when compiling the Icons project:
Solution we chose to implement was to create a project for each icon variant and change the core Icon project to reference these new projects and include the generated DLLs in the Icons package.
To do this, subclasses have been transformed into namespace (with the same name).
It is also necessary to centralize the
Icons
class (renamed toIconsExtensions
) in the Components library used by Icons and Emojis.