Skip to content

[Anchor] Revert #2624 and replace with a better solution #2640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 12, 2024
Merged

[Anchor] Revert #2624 and replace with a better solution #2640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7fbfbd9
Fix #2638
vnbaaij Sep 11, 2024
b87510b
Merge branch 'dev' into users/vnbaaij/fix-issue-#2638
dvoituron Sep 11, 2024
82226f3
Merge branch 'dev' into users/vnbaaij/fix-issue-#2638
vnbaaij Sep 12, 2024
155a9e6
Merge branch 'dev' into users/vnbaaij/fix-issue-#2638
vnbaaij Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion examples/Demo/Shared/Pages/Anchor/AnchorPage.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,11 @@

<DemoSection Title="Appearance" Component="@typeof(AnchorAppearance)" CollocatedFiles="@(new[] {"css"})"></DemoSection>

<DemoSection Title="Anchors with icons" Component="@typeof(AnchorIcons)"></DemoSection>
<DemoSection Title="Anchors with icons" Component="@typeof(AnchorIcons)">
<Description>
<p>By placing the icon the content of the anchor, it is possible to specify a <code>Color</code> for the icon.</p>
</Description>
</DemoSection>

<h2 id="documentation">Documentation</h2>

Expand Down
37 changes: 23 additions & 14 deletions examples/Demo/Shared/Pages/Anchor/Examples/AnchorIcons.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,43 @@
<h4>Neutral appearane</h4>
<div style="display: flex; align-items: center; gap: 10px; margin-bottom: 1em;">
<FluentAnchor Href="#" IconStart="@(new Icons.Regular.Size16.Globe())">
With icon at start
Icon at start
</FluentAnchor>

<FluentAnchor Href="#" IconEnd="@(new Icons.Regular.Size16.Globe())">
With icon at end
Icon at end
</FluentAnchor>

<FluentAnchor Href="#">
<FluentIcon Value="@(new Icons.Regular.Size16.Globe())" Color="@Color.Success" Slot="start" />
Icon at start in content
</FluentAnchor>

<FluentAnchor Href="#">
Icon at end in content
<FluentIcon Value="@(new Icons.Regular.Size16.Globe())" Color="@Color.Success" Slot="end" />
</FluentAnchor>
</div>
<h4>Hypertext appearane</h4>
<div style="display: flex; align-items: center; gap: 10px; margin-bottom: 1em;">
<FluentAnchor Appearance="@Appearance.Hypertext" Href="#" IconStart="@(new Icons.Regular.Size16.Globe())">
With icon at start
Icon at start
</FluentAnchor>

<FluentAnchor Appearance="@Appearance.Hypertext" Href="#" IconEnd="@(new Icons.Regular.Size16.Globe())">
With icon at end
Icon at end
</FluentAnchor>
</div>

<p>With icon in the content. By doing it this way, it is possible to specify <code>Color</code> for the icon.</p>
<FluentAnchor Href="#">
With icon in content
<FluentIcon Value="@(new Icons.Regular.Size32.Globe())" Color="@Color.Success" Slot="end" />
</FluentAnchor>
<FluentAnchor Appearance="@Appearance.Hypertext" Href="#">
<FluentIcon Value="@(new Icons.Regular.Size16.Globe())" Color="@Color.Success" Slot="start" />
Icon at start in content
</FluentAnchor>

<FluentAnchor Appearance="@Appearance.Hypertext" Href="#">
With icon in content
<FluentIcon Value="@(new Icons.Regular.Size32.Globe())" Color="@Color.Success" Slot="end" />
</FluentAnchor>
<FluentAnchor Appearance="@Appearance.Hypertext" Href="#">
Icon at start in content
<FluentIcon Value="@(new Icons.Regular.Size16.Globe())" Color="@Color.Success" Slot="end" />
</FluentAnchor>
</div>

<div style="display: flex; align-items: center; gap: 10px; margin-top: 1em;">
With icon in default slot:
Expand Down
9 changes: 6 additions & 3 deletions src/Core/Components/Anchor/FluentAnchor.razor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
fluent-anchor[appearance="hypertext"]::part(control) {
display: inline-flex !important;
}

fluent-anchor[appearance="hypertext"]::part(start) {
display: unset;
position: relative;
top: calc(var(--design-unit)* 1px);
margin-inline-end: calc(var(--design-unit) * 1px);
}

fluent-anchor[appearance="hypertext"]::part(end) {
display: unset;
position: relative;
top: calc(var(--design-unit)* 1px);
margin-inline-start: calc(var(--design-unit) * 1px);
}
Loading