Skip to content

Revert "[FluentSlider] Use current-value instead of value attribute in web component" #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Revert "[FluentSlider] Use current-value instead of value attribute in web component" #2591

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2cc52f
Revert "[FluentSlider] Use current-value instead of value attribute i…
vnbaaij Aug 28, 2024
24af368
Re-add binding test
vnbaaij Aug 29, 2024
69829e1
Merge branch 'dev' into revert-2438-dev
vnbaaij Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Core/Components/Slider/FluentSlider.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
orientation="@Orientation.ToAttributeValue()"
mode="@Mode.ToAttributeValue()"
id="@Id"
current-value="@FormatValueAsString(Value)"
value="@FormatValueAsString(Value)"
disabled="@Disabled"
name=@Name
required=@Required
Expand Down
0 ...s.FluentSliderLabel_Default.verified.html → ...s.FluentSliderLaber_Default.verified.html
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion tests/Core/Slider/FluentSliderLabelTests.cs → tests/Core/Slider/FluentSliderLaberTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public FluentSliderLabelTests()
}

[Fact]
public void FluentSliderLabel_Default()
public void FluentSliderLaber_Default()
{
//Arrange
var childContent = "<b>render me</b>";
Expand Down
2 changes: 1 addition & 1 deletion tests/Core/Slider/FluentSliderTests.FluentSlider_Default.verified.razor.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-slider class="horizontal" min="0" max="100" step="10" id="xxx" current-value="3" blazor:onchange="1" blazor:elementreference="xxx"></fluent-slider>
<fluent-slider class="horizontal" min="0" max="100" step="10" id="xxx" value="3" blazor:onchange="1" blazor:elementreference="xxx"></fluent-slider>
2 changes: 1 addition & 1 deletion tests/Core/Slider/FluentSliderTests.FluentSlider_Double.verified.razor.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-slider class="horizontal" min="-1.5" max="7" step="0.5" id="xxx" current-value="3.5" blazor:onsliderchange="1" blazor:elementreference="xxx"></fluent-slider>
<fluent-slider class="horizontal" min="-1.5" max="7" step="0.5" id="xxx" value="3.5" blazor:onsliderchange="1" blazor:elementreference="xxx"></fluent-slider>
2 changes: 1 addition & 1 deletion tests/Core/Slider/FluentSliderTests.FluentSlider_Horizontal.verified.razor.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-slider class="horizontal" min="0" max="100" step="10" orientation="horizontal" id="xxx" current-value="0" blazor:onchange="1" blazor:elementreference="xxx"></fluent-slider>
<fluent-slider class="horizontal" min="0" max="100" step="10" orientation="horizontal" id="xxx" value="0" blazor:onchange="1" blazor:elementreference="xxx"></fluent-slider>
2 changes: 1 addition & 1 deletion tests/Core/Slider/FluentSliderTests.FluentSlider_HorizontalImplicit.verified.razor.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-slider class="horizontal" min="0" max="100" step="10" id="xxx" current-value="0" blazor:onchange="1" blazor:elementreference="xxx"></fluent-slider>
<fluent-slider class="horizontal" min="0" max="100" step="10" id="xxx" value="0" blazor:onchange="1" blazor:elementreference="xxx"></fluent-slider>
2 changes: 1 addition & 1 deletion tests/Core/Slider/FluentSliderTests.FluentSlider_Vertical.verified.razor.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-slider class="vertical" min="0" max="100" step="10" orientation="vertical" id="xxx" current-value="0" blazor:onchange="1" blazor:elementreference="xxx"></fluent-slider>
<fluent-slider class="vertical" min="0" max="100" step="10" orientation="vertical" id="xxx" value="0" blazor:onchange="1" blazor:elementreference="xxx"></fluent-slider>
2 changes: 1 addition & 1 deletion tests/Core/Slider/FluentSliderTests.FluentSlider_WithLabel.verified.razor.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@

<label for="xxx" class="fluent-input-label" style="margin-bottom: calc(var(--design-unit) * 3px);" b-hum22yrq17="">label
</label>
<fluent-slider class="horizontal" min="0" max="100" step="10" id="xxx" current-value="0" blazor:onchange="1" blazor:elementreference="xxx"></fluent-slider>
<fluent-slider class="horizontal" min="0" max="100" step="10" id="xxx" value="0" blazor:onchange="1" blazor:elementreference="xxx"></fluent-slider>
2 changes: 1 addition & 1 deletion tests/Core/Slider/FluentSliderTests.FluentSlider_WithLabelTemplate.verified.razor.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
<label for="xxx" class="fluent-input-label" style="margin-bottom: calc(var(--design-unit) * 3px);" b-hum22yrq17="">
<strong>label</strong>
</label>
<fluent-slider class="horizontal" min="0" max="100" step="10" id="xxx" current-value="0" blazor:onchange="1" blazor:elementreference="xxx"></fluent-slider>
<fluent-slider class="horizontal" min="0" max="100" step="10" id="xxx" value="0" blazor:onchange="1" blazor:elementreference="xxx"></fluent-slider>
15 changes: 0 additions & 15 deletions tests/Core/Slider/FluentSliderTests.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,19 +77,4 @@
// Assert
cut.Verify();
}

[Fact]
public void FluentSlider_Binding()
{
// Arrange
int value = 3;
var cut = Render(@<FluentSlider Min="0" Max="10" Step="1" @bind-Value="@value"></FluentSlider>);

// Act
var slider = cut.Find("fluent-slider");
slider.TriggerEvent("onsliderchange", new ChangeEventArgs { Value = 2 });

// Assert
Assert.Equal(2, value);
}
}