Skip to content

Conversation

@vnbaaij
Copy link
Collaborator

@vnbaaij vnbaaij commented Aug 21, 2024

Fix #2517

Previously, we were not storing the initialColumnsWidth value for each DataGrid. With this PR that is changed.

As we only pass a simple ElementReference from C# to JS, we don't have any object uniquely identifying each grid. This is solved by setting the Id parameter in the FluentDataGrid constructor (and rendering it in the fluent-data-grid tag which was not being done yet!). The Id is then used as the key for the 'dictionary' on the JS side.

@vnbaaij vnbaaij requested a review from dvoituron as a code owner August 21, 2024 14:43
@github-actions
Copy link

github-actions bot commented Aug 21, 2024

Unit Tests

  • ❌[FAILED] Microsoft.FluentUI.AspNetCore.Components.Tests.Checkbox.FluentCheckboxThreeStatesTests.FluentCheckbox_ThreeStatesFalseAsync(initialValue: True, assertValue: False)

Details on your Workflow / Core Tests page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: ResetColumnWidths in FluentDataGrid

2 participants