Skip to content

Check for deleted status on Search Param update #4883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Check for deleted status on Search Param update #4883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...soft.Health.Fhir.Core/Features/Search/Parameters/CreateOrUpdateSearchParameterBehavior.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
{
var resourceKey = new ResourceKey(request.Resource.InstanceType, request.Resource.Id, request.Resource.VersionId);
ResourceWrapper prevSearchParamResource = await _fhirDataStore.GetAsync(resourceKey, cancellationToken);
if (prevSearchParamResource != null)
if (prevSearchParamResource != null && prevSearchParamResource.IsDeleted == false)

Check notice

Code scanning / CodeQL

Unnecessarily complex Boolean expression Note

The expression 'A == false' can be simplified to '!A'.

Copilot Autofix

AI 8 months ago

To fix the problem, we need to simplify the Boolean expression prevSearchParamResource.IsDeleted == false to !prevSearchParamResource.IsDeleted. This change will make the code more readable and maintainable without altering its functionality.

  • Locate the expression prevSearchParamResource.IsDeleted == false in the file src/Microsoft.Health.Fhir.Core/Features/Search/Parameters/CreateOrUpdateSearchParameterBehavior.cs.
  • Replace the expression with !prevSearchParamResource.IsDeleted.
Suggested changeset 1
src/Microsoft.Health.Fhir.Core/Features/Search/Parameters/CreateOrUpdateSearchParameterBehavior.cs

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/src/Microsoft.Health.Fhir.Core/Features/Search/Parameters/CreateOrUpdateSearchParameterBehavior.cs b/src/Microsoft.Health.Fhir.Core/Features/Search/Parameters/CreateOrUpdateSearchParameterBehavior.cs
--- a/src/Microsoft.Health.Fhir.Core/Features/Search/Parameters/CreateOrUpdateSearchParameterBehavior.cs
+++ b/src/Microsoft.Health.Fhir.Core/Features/Search/Parameters/CreateOrUpdateSearchParameterBehavior.cs
@@ -54,3 +54,3 @@
                 ResourceWrapper prevSearchParamResource = await _fhirDataStore.GetAsync(resourceKey, cancellationToken);
-                if (prevSearchParamResource != null && prevSearchParamResource.IsDeleted == false)
+                if (prevSearchParamResource != null && !prevSearchParamResource.IsDeleted)
                 {
EOF
@@ -54,3 +54,3 @@
ResourceWrapper prevSearchParamResource = await _fhirDataStore.GetAsync(resourceKey, cancellationToken);
if (prevSearchParamResource != null && prevSearchParamResource.IsDeleted == false)
if (prevSearchParamResource != null && !prevSearchParamResource.IsDeleted)
{
Copilot is powered by AI and may make mistakes. Always verify output.
{
// Update the SearchParameterDefinitionManager with the new SearchParameter in order to validate any changes
// to the fhirpath or the datatype
Expand Down
Loading