Skip to content

Increase max valueset size to 20,000 #4850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Increase max valueset size to 20,000 #4850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/Microsoft.Health.Fhir.Shared.Core/Features/Validation/ProfileValidator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
using Hl7.Fhir.ElementModel;
using Hl7.Fhir.Model;
using Hl7.Fhir.Specification.Source;
using Hl7.Fhir.Specification.Terminology;
using Hl7.Fhir.Validation;
using Microsoft.Extensions.Options;
using Microsoft.Health.Fhir.Core.Configs;
Expand Down Expand Up @@ -38,12 +39,20 @@ public ProfileValidator(IProvideProfilesForValidation profilesResolver, IOptions

private Validator GetValidator()
{
var expanderSettings = new ValueSetExpanderSettings
{
MaxExpansionSize = 20000, // Set your desired max expansion size here
Copy link
Contributor

@LTA-Thinking LTA-Thinking Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did we get the 20,000 from? Was that the default value for Firely until we upgraded?

Copy link
Contributor Author

@feordin feordin Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current valueset expansion that is being used is ~17,000. The 20,000 give a bit of a buffer, but I don't want much larger than necessary.

Copy link
Contributor

@mikaelweave mikaelweave Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we set this from a configuration somewhere?

Copy link
Contributor Author

@feordin feordin Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add a setting, and make it configurable. But I wanted a quick change to address this issue. Then we can consider a more in depth change.

};

var terminologyService = new LocalTerminologyService(_resolver.AsAsync(), expanderSettings);

var ctx = new ValidationSettings()
{
ResourceResolver = _resolver,
GenerateSnapshot = true,
Trace = false,
ResolveExternalReferences = false,
TerminologyService = terminologyService,
};

var validator = new Validator(ctx);
Expand Down
Loading