Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fluent UI to Creator #4965

Merged
merged 8 commits into from
Jul 23, 2021
Merged

Conversation

janechu
Copy link
Collaborator

@janechu janechu commented Jul 17, 2021

Pull Request

📖 Description

This change adds the Fluent UI web component library to Creator. There is a slight issue in Fluent UI which means the build will fail until a publish in Fluent UI fixes the issue. See microsoft/fluentui#18987.

👩‍💻 Reviewer Notes

Once this is unblocked by microsoft/fluentui#18987 you will see that two buttons now show up in the left tab, FAST components and Fluent UI components. Both can be added, there are a few caveats however, we are using the Design Tokens from FAST for editing in the right pane. This means that when adding Fluent UI components, the accent color is available but will not affect any components. Additionally, if both component libraries are added, there may be some discrepancies between packages. There is also an issue where both libraries have components that are named the same. This will need to be resolved by prefixing or affixing the library name. See next steps for a future resolution.

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

⏭ Next Steps

  • Allow libraries to add an additional pane to the right rail for configuration, this will be used for the Design Tokens for FAST and Fluent UI component libraries but should be open ended enough to allow for any extra library configuration to take place
  • Prefix or affix the library name to the component name in the Form and Navigation

Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor tweak or two. The code also shows me that we've got a bug in the core libraries. So, I'll create a PR to fix that situation in fast and fluent shortly. We can update this code to use the improved API when ready but this can merge without that if we adjust the prefix API as noted.

Copy link
Contributor

@nicholasrice nicholasrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good aside from the already highlighted issues.

@janechu janechu force-pushed the users/janechu/add-fluent-ui-to-creator branch from fa9539f to 4e489a0 Compare July 21, 2021 05:57
@janechu janechu force-pushed the users/janechu/add-fluent-ui-to-creator branch from 4e489a0 to 30aeaab Compare July 23, 2021 18:18
@EisenbergEffect EisenbergEffect self-requested a review July 23, 2021 19:39
@janechu janechu merged commit df8a6b1 into master Jul 23, 2021
@janechu janechu deleted the users/janechu/add-fluent-ui-to-creator branch July 23, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants