Windows Support #40
Open
Windows Support #40
+255
−148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
husseinmozannar
commented
Dec 2, 2025
Contributor
Author
There was a problem hiding this comment.
formatting only
husseinmozannar
commented
Dec 2, 2025
Contributor
Author
There was a problem hiding this comment.
formatting only
husseinmozannar
commented
Dec 2, 2025
| all_observations.append(action_description) | ||
| self.logger.info(f"Observation#{i+1}: {action_description}") | ||
| self.logger.debug(f"Observation#{i+1}: {action_description}") | ||
| print(f"Observation#{i+1}: {action_description}") |
Contributor
Author
There was a problem hiding this comment.
windows dont show the logger so added print
husseinmozannar
commented
Dec 2, 2025
| Issues = "https://github.com/microsoft/fara/issues" | ||
|
|
||
| [project.optional-dependencies] | ||
| vllm = ["vllm>=0.10.0"] |
Contributor
Author
There was a problem hiding this comment.
vllm crashes windows install, so kept optional
|
|
||
| Notes: | ||
| - If you're using Windows, we highly recommend using WSL2 (Windows Subsystem for Linux). | ||
| - If you're using Windows, we highly recommend using WSL2 (Windows Subsystem for Linux). Please the Windows instructions in the [Installation](#Installation) section. |
There was a problem hiding this comment.
Please the Windows instructions in the Installation section
Missing word?
Please FOLLOW the Windows instructions...?
Please VIEW the Windows instructions...?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fixes to enable windows support for fara-cli and install instructions.
Closes #32