Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added rules for dialog #91

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Added rules for dialog #91

merged 2 commits into from
Sep 17, 2024

Conversation

sudgata
Copy link
Contributor

@sudgata sudgata commented Sep 16, 2024

Added rules for Dialogs.

  1. dialogsurface-needs-aria
  2. dialogbody-needs-title-content-and-actions

@sudgata sudgata linked an issue Sep 16, 2024 that may be closed by this pull request
Dialog needs an accessible name #52
Closed
@sudgata
Copy link
Contributor Author

sudgata commented Sep 16, 2024

@microsoft-github-policy-service agree company="Microsoft"

@sudgata sudgata requested a review from aubreyquinn September 16, 2024 22:31
aubreyquinn
aubreyquinn approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@aubreyquinn aubreyquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! I wonder if we would want to add a rule for the Dialog component and trigger itself in a different rule? e.g.

 <Dialog>
      <DialogTrigger disableButtonEnhancement>
        <Button>Open dialog</Button>
      </DialogTrigger>

@aubreyquinn aubreyquinn merged commit 5728487 into main Sep 17, 2024
1 check passed
@aubreyquinn aubreyquinn deleted the shubhakanta-dialog branch September 17, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aubreyquinn aubreyquinn aubreyquinn approved these changes

Assignees

@sudgata sudgata

@aubreyquinn aubreyquinn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dialog needs an accessible name
2 participants
@sudgata @aubreyquinn