Adds labelling for toggle button v9 and adds a rule for no empty buttons #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shweta786
reviewed
Mar 13, 2024
shweta786
approved these changes
Mar 13, 2024
aubreyquinn
requested changes
Mar 14, 2024
aubreyquinn
changed the title
This was referenced Mar 14, 2024
aubreyquinn
requested changes
Mar 14, 2024
aubreyquinn
reviewed
Mar 14, 2024
aubreyquinn
reviewed
Mar 14, 2024
aubreyquinn
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates rule for no empty button in v9, and also handles labelling for toggle buttons.
Related work item emptyButtonRule, toggleButton
NOTE: The scenario including icons and button/ToggleButton are already taken care of in this file
image-button-missing-aria-v9