Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Rule for dropdown #55

Merged
merged 12 commits into from
Mar 13, 2024

Conversation

shweta786
Copy link
Collaborator

Dropdown menu must have a visual label and it needs to be linked via aria-labelledby
Related work item

Copy link
Collaborator

@aubreyquinn aubreyquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

docs/rules/dropdown-needs-arialabeledby-and-label-v9.md Outdated Show resolved Hide resolved
lib/rules/dropdown-needs-arialabeledby-and-label-v9.js Outdated Show resolved Hide resolved
lib/rules/dropdown-needs-arialabeledby-and-label-v9.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@nikitasingla-MSFT nikitasingla-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to make changes in lib/rules/index.js as well

@aubreyquinn aubreyquinn merged commit c0981f1 into microsoft:main Mar 13, 2024
4 checks passed
@aubreyquinn aubreyquinn linked an issue Mar 14, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility Rule: Dropdown needs a label
4 participants