Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input rules support aria label #129

Closed
wants to merge 2 commits into from

Conversation

otkHsiao
Copy link

@otkHsiao otkHsiao commented Oct 21, 2024

In the rules of the input component, you may have forgotten to add the detection rules of arialabel.

Fixes #128

@otkHsiao
Copy link
Author

@microsoft-github-policy-service agree company="Microsoft"

Copy link
Collaborator

@aubreyquinn aubreyquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While aria-label will work for assistive technology users, it's not very good for sighted users. The ideal situation is to have a visual label that has a relationship to the input field so the input field has an accessible name. I guess it's a WCAG violation if the input does not have an accessible name... I'm thinking this could be a warning for this specific case?

@otkHsiao
Copy link
Author

While aria-label will work for assistive technology users, it's not very good for sighted users. The ideal situation is to have a visual label that has a relationship to the input field so the input field has an accessible name. I guess it's a WCAG violation if the input does not have an accessible name... I'm thinking this could be a warning for this specific case?

Thank you for your detailed and patient explanation! I understand now.

@otkHsiao otkHsiao closed this Oct 30, 2024
@otkHsiao otkHsiao deleted the inputRulesSupportAriaLabel branch October 30, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arialabel rule detection error in <Input> component
2 participants