Skip to content

Make the ICU SONAME configurable #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 19, 2025
Merged

Make the ICU SONAME configurable #495

merged 5 commits into from
Jun 19, 2025

Conversation

@lhecker
Copy link
Member

@lhecker lhecker commented Jun 18, 2025 •
edited
Loading

This PR was tested on Ubuntu with:

EDIT_CFG_ICUUC_SONAME=libicuuc.so.74
EDIT_CFG_ICUI18N_SONAME=libicui18n.so.74
EDIT_CFG_ICU_RENAMING_VERSION=74
cargo build --config .cargo/release.toml --release

Search & Replace now works flawlessly. I hope that package maintainers
will be able to make use of this when ingesting future versions of Edit.

Closes #172

@lhecker lhecker force-pushed the dev/lhecker/linux-icu-soname branch from a36f3d6 to e6aad7c Compare June 18, 2025 14:35
@lhecker lhecker mentioned this pull request Jun 19, 2025
Closed
DHowett
DHowett reviewed Jun 19, 2025
View reviewed changes
README.md
This project _optionally_ depends on the ICU library for its Search and Replace functionality.
By default, the project will look for a SONAME without version suffix:
* Windows: `icuuc.dll`
* macOS: `libicuuc.dylib`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think macOS only has libicucore, and not uc/i18n... hmm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it also exports all of them as C++ symbols, i.e. with underscore prefix.

@lhecker lhecker requested a review from DHowett June 19, 2025 19:48
@lhecker lhecker merged commit b277a1e into main Jun 19, 2025
3 checks passed
@lhecker lhecker deleted the dev/lhecker/linux-icu-soname branch June 19, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DHowett DHowett DHowett approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Linux: This operation requires the ICU library

2 participants

@lhecker @DHowett