[draft] km_stress_test fixes #4117
Draft
+985
−848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewige
changed the title
matthewige
commented
Jan 29, 2025
| { | ||
| NET_EBPF_EXT_LOG_ENTRY(); | ||
|
|
||
| ExWaitForRundownProtectionRelease(&rundown->protection); | ||
| rundown->rundown_occurred = TRUE; | ||
| if (rundown->rundown_initialized == TRUE) { |
There was a problem hiding this comment.
It looks to me like this is the crux of the fix. I haven't been able to reason out why this resolves the issue though.
Based on the test failure crash dump hang, we are waiting (forever) on DriverUnload. In that code path, I can't find a place where we would be invoking this function on an uninitialized rundown object.
matthewige
commented
Jan 29, 2025
scripts/run_driver_tests.psm1
Outdated
| @@ -460,7 +459,7 @@ function Invoke-ConnectRedirectTest | |||
| function Invoke-CICDStressTests | |||
| { | |||
| param([parameter(Mandatory = $true)][bool] $VerboseLogs, | |||
| [parameter(Mandatory = $false)][int] $TestHangTimeout = 3600, | |||
| [parameter(Mandatory = $false)][int] $TestHangTimeout = (45*60), | |||
There was a problem hiding this comment.
The stress tests were NOT passing any timeout value, which would mean a default of 10 minutes. However, there are multiple stress test cases, which each utilize the -td=5 (5 minutes) test parameter. So surely this is insufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the purpose of and changes within this Pull Request.
Testing
Do any existing tests cover this change? Are new tests needed?
Documentation
Is there any documentation impact for this change?
Installation
Is there any installer impact for this change?