Fix for breaking change P2905R2 in STL #3589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Jowett <[email protected]>
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag,
shankarseal,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
dthaler
approved these changes
May 28, 2024
saxena-anurag
approved these changes
May 29, 2024
shankarseal
pushed a commit
to shankarseal/ebpf-for-windows
that referenced
this pull request
Jun 14, 2024
Signed-off-by: Alan Jowett <[email protected]> Co-authored-by: Alan Jowett <[email protected]> fix bad merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #3579
Description
The proposal P2905R2 makes a breaking change to make_format_args to reject temporary values as arguments. Workaround is to create place holder variables to hold temporary and extend there lifetime.
Testing
CI/CD
Documentation
No.
Installation
No.