Cleanup batch APIs and remove unused parameter #3580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Jowett <[email protected]>
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag,
shankarseal,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
dthaler
approved these changes
May 24, 2024
saxena-anurag
approved these changes
May 29, 2024
shankarseal
pushed a commit
to shankarseal/ebpf-for-windows
that referenced
this pull request
Jun 3, 2024
Signed-off-by: Alan Jowett <[email protected]> Co-authored-by: Alan Jowett <[email protected]> Co-authored-by: Sharmi <[email protected]>
shankarseal
added a commit
that referenced
this pull request
Jun 5, 2024
* Phase 1 of removing the rundown protection for invoke (#3534) * Phase 1 of removing the rundown protection for invoke Signed-off-by: Alan Jowett <[email protected]> * Fix SAL annotation error Signed-off-by: Alan Jowett <[email protected]> * PR feedback Signed-off-by: Alan Jowett <[email protected]> * PR feedback Signed-off-by: Alan Jowett <[email protected]> * Phase 1 of removing the rundown protection for invoke Signed-off-by: Alan Jowett <[email protected]> * Fix SAL annotation error Signed-off-by: Alan Jowett <[email protected]> * PR feedback Signed-off-by: Alan Jowett <[email protected]> * PR feedback Signed-off-by: Alan Jowett <[email protected]> * Ensure that _ebpf_program_free always run outside of an epoch to prevent deadlocks Signed-off-by: Alan Jowett <[email protected]> * Revert unrelated change Signed-off-by: Alan Jowett <[email protected]> * PR feedback and leak fix Signed-off-by: Alan Jowett <[email protected]> --------- Signed-off-by: Alan Jowett <[email protected]> Co-authored-by: Alan Jowett <[email protected]> * Cache choco packages to work around connectivity issues (#3536) * Cache choco packages to work around connectivity issues Signed-off-by: Alan Jowett <[email protected]> * Download file as cache key if needed Signed-off-by: Alan Jowett <[email protected]> * Skip choco if gather_dumps is false Signed-off-by: Alan Jowett <[email protected]> * Skip choco if gather_dumps is false Signed-off-by: Alan Jowett <[email protected]> * Apply suggestions from code review Co-authored-by: Dave Thaler <[email protected]> --------- Signed-off-by: Alan Jowett <[email protected]> Co-authored-by: Alan Jowett <[email protected]> Co-authored-by: Dave Thaler <[email protected]> * Add option to control the level of verbosity emitted by verifier. (#3570) * Add option to control the level of verbosity emitted by verifier. Signed-off-by: Alan Jowett <[email protected]> * Re-order enums to make normal < informational < verbose Signed-off-by: Alan Jowett <[email protected]> * Apply suggestions from code review Co-authored-by: Dave Thaler <[email protected]> * PR feedback Signed-off-by: Alan Jowett <[email protected]> * Workaround for verifier failure #643 Signed-off-by: Alan Jowett <[email protected]> * Revert change in ebpf-service verification path Signed-off-by: Alan Jowett <[email protected]> --------- Signed-off-by: Alan Jowett <[email protected]> Co-authored-by: Alan Jowett <[email protected]> Co-authored-by: Dave Thaler <[email protected]> * Add `total_size` to extension header. (#3573) * change ebpf_extension_header_t to ebpf_version_header_t * revert to ebpf_version_header_t * revert to ebpf_version_header_t * update header * update doc * update doc * use total_size to get the actual struct size * Apply suggestions from code review Co-authored-by: Dave Thaler <[email protected]> --------- Co-authored-by: Dave Thaler <[email protected]> * disable tailcall test for now (#3558) Co-authored-by: Dhiren Vispute <[email protected]> * Cleanup batch APIs and remove unused parameter (#3580) Signed-off-by: Alan Jowett <[email protected]> Co-authored-by: Alan Jowett <[email protected]> Co-authored-by: Sharmi <[email protected]> * Add support for multiple programs per section (#3557) * Allow multiple programs per section Temporarily use a fork of ebpf-verifier until vbpf/ebpf-verifier#642 is merged. Per https://stackoverflow.com/questions/13147170/attribute-always-inline-failing the __attribute__((always_inline)) doesn't do anything unless you also have the "inline" keyword. Signed-off-by: Dave Thaler <[email protected]> * Update verifier to latest Signed-off-by: Dave Thaler <[email protected]> * Address comment from Alan Signed-off-by: Dave Thaler <[email protected]> * Address API compat comment from Anurag Signed-off-by: Dave Thaler <[email protected]> --------- Signed-off-by: Dave Thaler <[email protected]> * Add workaround for NmrRegisterClient calling detach (#3594) Signed-off-by: Alan Jowett <[email protected]> Co-authored-by: Alan Jowett <[email protected]> * move enum to header (#3593) --------- Signed-off-by: Alan Jowett <[email protected]> Signed-off-by: Dave Thaler <[email protected]> Co-authored-by: Alan Jowett <[email protected]> Co-authored-by: Alan Jowett <[email protected]> Co-authored-by: Dave Thaler <[email protected]> Co-authored-by: Anurag Saxena <[email protected]> Co-authored-by: Dhiren Vispute <[email protected]> Co-authored-by: Dhiren Vispute <[email protected]> Co-authored-by: Sharmi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request primarily focuses on simplifying the function signatures for batch invocation in the eBPF program. The changes remove the
extension_client_binding_contextparameter from various functions across multiple files, making the functions easier to use since they now require fewer arguments.Here are the key changes:
Removal of
extension_client_binding_contextparameter:docs/eBpfExtensions.md: Theextension_client_binding_contextparameter was removed from theebpf_program_batch_begin_invoke_function_t,ebpf_program_batch_end_invoke_function_tfunctions. [1] [2] [3]include/ebpf_extension.h: Theextension_client_binding_contextparameter was removed from theebpf_program_batch_begin_invoke_function_t,ebpf_program_batch_end_invoke_function_tfunctions. [1] [2] [3]libs/execution_context/ebpf_link.c: Theextension_client_binding_contextparameter was removed from the_ebpf_link_instance_invoke_batch_begin,_ebpf_link_instance_invoke_batch_endfunctions and their usages. [1] [2] [3] [4]tests/end_to_end/helpers.h: Theextension_client_binding_contextparameter was removed from thebatch_begin_function,batch_invoke_function,batch_end_functionfunctions. [1] [2]undocked/tests/sample/ext/drv/sample_ext.c: Theextension_client_binding_contextparameter was removed from thesample_ebpf_extension_invoke_batch_begin_program,sample_ebpf_extension_invoke_batch_end_programfunctions. [1] [2]Testing
CI/CD
Documentation
Yes.
Installation
No.