Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bpf_map_lookup_batch] Add test case to retrieve data in batches #3563

Merged
merged 5 commits into from
May 24, 2024
Merged

[bpf_map_lookup_batch] Add test case to retrieve data in batches #3563

merged 5 commits into from
May 24, 2024

Conversation

shpalani
Copy link
Collaborator

Description

  1. Added the missing test case to retrieve in batches.
  2. Added BPF_MAP_TYPE_LRU_HASH map test.

Testing

_Do any existing tests cover this change? No.
Are new tests needed? Yes

Documentation

_Is there any documentation impact for this change? No

Installation

_Is there any installer impact for this change? No

This was referenced May 21, 2024
Open
Closed
@shpalani shpalani linked an issue May 21, 2024 that may be closed by this pull request
bpf_map_lookup_batch: Add test cases to fetch data in batches #3565
Closed
Alan-Jowett
Alan-Jowett requested changes May 21, 2024
View reviewed changes
Copy link
Member

@Alan-Jowett Alan-Jowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please either remove the "concurrent_delete" flag or make use of it. As it stands right now this is dead code.

dthaler
dthaler reviewed May 21, 2024
View reviewed changes
tests/unit/libbpf_test.cpp Outdated Show resolved Hide resolved
tests/unit/libbpf_test.cpp Outdated Show resolved Hide resolved
@shpalani
Copy link
Collaborator Author

Please either remove the "concurrent_delete" flag or make use of it. As it stands right now this is dead code.

Removed.

@shpalani shpalani closed this May 21, 2024
@shpalani shpalani reopened this May 21, 2024
@shpalani shpalani requested a review from Alan-Jowett May 23, 2024 17:26
@dthaler dthaler added this pull request to the merge queue May 24, 2024
Merged via the queue into microsoft:main with commit 10fdbbc May 24, 2024
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dthaler dthaler dthaler approved these changes

@Alan-Jowett Alan-Jowett Alan-Jowett approved these changes

@poornagmsft poornagmsft Awaiting requested review from poornagmsft poornagmsft is a code owner

@saxena-anurag saxena-anurag Awaiting requested review from saxena-anurag saxena-anurag is a code owner

@shankarseal shankarseal Awaiting requested review from shankarseal shankarseal is a code owner

@dv-msft dv-msft Awaiting requested review from dv-msft dv-msft is a code owner

@gtrevi gtrevi Awaiting requested review from gtrevi gtrevi is a code owner

@matthewige matthewige Awaiting requested review from matthewige matthewige is a code owner

@mtfriesen mtfriesen Awaiting requested review from mtfriesen mtfriesen is a code owner

@rectified95 rectified95 Awaiting requested review from rectified95 rectified95 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bpf_map_lookup_batch: Add test cases to fetch data in batches
3 participants
@shpalani @dthaler @Alan-Jowett