Revert overly strict check in link attach to provider #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Jowett <[email protected]>
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag,
shankarseal,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
gtrevi
approved these changes
Apr 24, 2024
saxena-anurag
approved these changes
Apr 24, 2024
shankarseal
approved these changes
Apr 25, 2024
shankarseal
pushed a commit
to shankarseal/ebpf-for-windows
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Alan Jowett <[email protected]> Co-authored-by: Alan Jowett <[email protected]>
shankarseal
added a commit
that referenced
this pull request
Apr 25, 2024
* Fixes for memory leaks and crashes (#3485) * test * fix * fix * fix * fix * fix * more fixes * fix * fix * fix * Revert "test" This reverts commit ff02406. * fix * fix * Revert overly strict check in link attach to provider (#3495) Signed-off-by: Alan Jowett <[email protected]> Co-authored-by: Alan Jowett <[email protected]> --------- Signed-off-by: Alan Jowett <[email protected]> Co-authored-by: Anurag Saxena <[email protected]> Co-authored-by: Alan Jowett <[email protected]> Co-authored-by: Alan Jowett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves: #3484
The values bpf_attach_type and link_type aren't meaningful to ebpfcore and it shouldn't block new values.
Copilot summary:
This pull request primarily focuses on enhancing the logging and error reporting mechanism in the
libs/execution_contextandlibs/shareddirectories. The key changes include the addition of more detailed logging messages and the removal of certain conditions in theebpf_validate_attach_provider_datafunction.Enhancements to logging and error reporting:
libs/execution_context/ebpf_link.c: In the_ebpf_link_client_attach_providerfunction, the logging mechanism has been updated to provide more detailed information when the provider'sModuleIdorprogram_typedoes not match the link'sattach_typeorprogram_typerespectively.libs/execution_context/ebpf_program.c: In the_ebpf_program_type_specific_program_information_attach_providerfunction, the log message now includes theprogram_typeandModuleIdin case of a module ID mismatch.libs/shared/shared_common.c: In theebpf_validate_attach_provider_datafunction, the conditions checking thelink_typeandbpf_attach_typehave been removed, simplifying the function.Testing
CI/CD + testing with ntosebpfext
Documentation
No.
Installation
No.