Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the MSI installer contents. #3333

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Conversation

gtrevi
Copy link
Collaborator

@gtrevi gtrevi commented Mar 7, 2024

Closes #3332
Closes #3313
Closes #2969

Description

This PR refactors the MSI to be focused of the eBPF platform installation only, while local development is already addressed by the NuGet package, and full development (i.e. project contribution) by cloning/forking the GiHub project.

Testing

Local, CICD.

Documentation

InstallingEbpf.md

Installation

MSI installer package.

@gtrevi gtrevi changed the title draft Refactor the MSI installer contents. Mar 7, 2024
@shankarseal
Copy link
Collaborator

Can you please add changes to this PR to address #2422 as well? I also think #1279 should be addressed by this PR.
I think you can also close #2969 with this PR as we decided that the MSI will not deploy any test bits.

@gtrevi gtrevi requested a review from rectified95 March 12, 2024 21:53
@gtrevi gtrevi added this pull request to the merge queue Mar 12, 2024
Merged via the queue into microsoft:main with commit 5e84f5c Mar 12, 2024
80 checks passed
@gtrevi gtrevi deleted the gtrevi/refactor-msi branch March 23, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants