Switch synchronous thread to thread_local storage #3330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Jowett <[email protected]>
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag,
shankarseal,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
|
Need to investigate failures. |
Signed-off-by: Alan Jowett <[email protected]>
|
Isusue resolved, ready for review. |
|
Code itself looks good to me, but do we have existing tests which utilize ebpf api on multiple threads? |
matthewige
reviewed
Mar 5, 2024
Signed-off-by: Alan Jowett <[email protected]>
Added dedicates IOCTL stress test, FWIW. |
matthewige
approved these changes
Mar 6, 2024
gtrevi
reviewed
Mar 6, 2024
Alan-Jowett
commented
Mar 6, 2024
| } | ||
| } | ||
|
|
||
| // Wait for 10 seconds |
There was a problem hiding this comment.
Comment is out of date.
saxena-anurag
approved these changes
Mar 6, 2024
shankarseal
pushed a commit
to shankarseal/ebpf-for-windows
that referenced
this pull request
Mar 22, 2024
* Switch synchronous thread to thread_local storage Signed-off-by: Alan Jowett <[email protected]> * Add dedicated calls to cleanup device handles on thread attach/detach Signed-off-by: Alan Jowett <[email protected]> * Add dedicate test to stress device handling Signed-off-by: Alan Jowett <[email protected]> --------- Signed-off-by: Alan Jowett <[email protected]> Co-authored-by: Alan Jowett <[email protected]>
Closed
shankarseal
pushed a commit
to shankarseal/ebpf-for-windows
that referenced
this pull request
Mar 22, 2024
* Switch synchronous thread to thread_local storage Signed-off-by: Alan Jowett <[email protected]> * Add dedicated calls to cleanup device handles on thread attach/detach Signed-off-by: Alan Jowett <[email protected]> * Add dedicate test to stress device handling Signed-off-by: Alan Jowett <[email protected]> --------- Signed-off-by: Alan Jowett <[email protected]> Co-authored-by: Alan Jowett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IOCTLs sent via a file handle that is opened without the FILE_FLAG_OVERLAPPED flag are serialized in the file object. This will affect performance if multiple user mode threads are making concurrent IOCTL requests.
This change switches the synchronous handle to being per-thread, with the handle being closed on thread detach.
Testing
CI/CD
Documentation
No.
Installation
No.