Fix scorecards workflow runs #3303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/microsoft/ebpf-for-windows/actions/workflows/scorecards-analysis.yml?query=branch%3Amain shows that the scorecards workflow is consistently failing in main. As can be seen at https://app.stepsecurity.io/github/microsoft/ebpf-for-windows/actions/runs/8052805389 we are hitting the errors because the score card action tries to access www.bestpractices.dev. This is the new name of bestpractices.coreinfrastructure.org which was allowed (indeed if you try to go to that site in a browser, it now redirects to www.bestpractices.dev). This updates the ACL with the new domain name. Signed-off-by: Dave Thaler <[email protected]>
dthaler
requested review from
poornagmsft,
Alan-Jowett,
saxena-anurag,
shankarseal,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
gtrevi
approved these changes
Feb 27, 2024
saxena-anurag
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/microsoft/ebpf-for-windows/actions/workflows/scorecards-analysis.yml?query=branch%3Amain shows that the scorecards workflow is consistently failing in main.
As can be seen at
https://app.stepsecurity.io/github/microsoft/ebpf-for-windows/actions/runs/8052805389 we are hitting the errors because the score card action tries to access www.bestpractices.dev. This is the new name of
bestpractices.coreinfrastructure.org which was allowed (indeed if you try to go to that site in a browser, it now redirects to www.bestpractices.dev). This updates the ACL with the new domain name.
Testing
Covered by CI/CD.
Documentation
No impact.
Installation
No impact.