-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable optimization on bpf2c generated code #3146
Conversation
Signed-off-by: Alan Jowett <[email protected]>
Signed-off-by: Alan Jowett <[email protected]>
Signed-off-by: Alan Jowett <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you help clarify the significance of the below options?
Can you help clarify the significance of the below options?
This will also help to know why is BasicRuntimeChecks not used in the kernel mode. Thanks. |
BasicRuntimeChecks are not supported in kernel mode. The full list of options for this configuration node are here: |
Thanks for sharing the link. Going through the list of options, I found the below to be useful too! |
" Size\n" | ||
" Section Type (bytes)\n" | ||
"==================== ========= =======\n" | ||
#if defined(NDEBUG) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This if
tests whether the unit tests were compiled for Debug or Release, not whether bpf.sys was compiled for Debug or Release. As such, this test will fail in some manual cases. It would be better to accept both sizes, not only one size.
Description
Enable optimization flag when generating release versions of native binaries.
Testing
CI/CD
Documentation
No.
Installation
No.