-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove store km lib and code #3109
Merged
saxena-anurag
merged 4 commits into
microsoft:main
from
saxena-anurag:user/anusa/remove_km_store_apis
Dec 12, 2023
Merged
Remove store km lib and code #3109
saxena-anurag
merged 4 commits into
microsoft:main
from
saxena-anurag:user/anusa/remove_km_store_apis
Dec 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saxena-anurag
changed the title
[DRAFT] remove store km lib and code
Remove store km lib and code
Dec 8, 2023
saxena-anurag
requested review from
dthaler,
poornagmsft,
Alan-Jowett,
shankarseal,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
December 8, 2023 23:17
dthaler
previously approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, modulo some nits in comments.
dthaler
previously approved these changes
Dec 9, 2023
Should we link this to an issue, to track the new specification end-to-end? |
2 tasks
Filed and linked #3123 to this PR. |
Co-authored-by: Dave Thaler <[email protected]>
saxena-anurag
force-pushed
the
user/anusa/remove_km_store_apis
branch
from
December 11, 2023 19:56
1dda23b
to
20ee96c
Compare
gtrevi
approved these changes
Dec 12, 2023
mtfriesen
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3123
Description
Per discussion in last triage meeting, we need to remove km store libs, and only um store libs will be published from ebpfapi.
This PR removes km store libs.
Testing
Existing CICD
Documentation
Updated doc in this PR.
Installation
No.