Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove store km lib and code #3109

Merged

Conversation

saxena-anurag
Copy link
Contributor

@saxena-anurag saxena-anurag commented Dec 8, 2023

Fixes #3123

Description

Per discussion in last triage meeting, we need to remove km store libs, and only um store libs will be published from ebpfapi.
This PR removes km store libs.

Testing

Existing CICD

Documentation

Updated doc in this PR.

Installation

No.

@saxena-anurag saxena-anurag changed the title [DRAFT] remove store km lib and code Remove store km lib and code Dec 8, 2023
@saxena-anurag saxena-anurag marked this pull request as ready for review December 8, 2023 23:17
dthaler
dthaler previously approved these changes Dec 8, 2023
Copy link
Collaborator

@dthaler dthaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, modulo some nits in comments.

docs/eBpfExtensions.md Outdated Show resolved Hide resolved
docs/eBpfExtensions.md Outdated Show resolved Hide resolved
dthaler
dthaler previously approved these changes Dec 9, 2023
@gtrevi
Copy link
Collaborator

gtrevi commented Dec 11, 2023

Should we link this to an issue, to track the new specification end-to-end?

@saxena-anurag
Copy link
Contributor Author

Should we link this to an issue, to track the new specification end-to-end?

Filed and linked #3123 to this PR.

@saxena-anurag saxena-anurag added this pull request to the merge queue Dec 12, 2023
Merged via the queue into microsoft:main with commit f6a4788 Dec 12, 2023
76 checks passed
@saxena-anurag saxena-anurag deleted the user/anusa/remove_km_store_apis branch December 12, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove KM version of eBPF store APIs
4 participants