-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connected UDP tests to cgroup/sock_addr_connect #3041
Merged
saxena-anurag
merged 21 commits into
microsoft:main
from
matthewige:user/maige/connectedUDPTests
Dec 12, 2023
Merged
Add connected UDP tests to cgroup/sock_addr_connect #3041
saxena-anurag
merged 21 commits into
microsoft:main
from
matthewige:user/maige/connectedUDPTests
Dec 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewige
changed the title
User/maige/connected udp tests
[DRAFT] Add connected UDP tests to cgroup/sock_addr_connect
Nov 10, 2023
This was
linked to
issues
Nov 15, 2023
matthewige
changed the title
[DRAFT] Add connected UDP tests to cgroup/sock_addr_connect
Add connected UDP tests to cgroup/sock_addr_connect
Nov 15, 2023
matthewige
requested review from
dthaler,
poornagmsft,
Alan-Jowett,
saxena-anurag,
shankarseal,
dv-msft,
gtrevi,
shpalani and
mtfriesen
as code owners
November 15, 2023 16:26
Alan-Jowett
previously approved these changes
Nov 16, 2023
saxena-anurag
previously approved these changes
Nov 18, 2023
dthaler
reviewed
Nov 19, 2023
matthewige
dismissed stale reviews from saxena-anurag and Alan-Jowett
via
December 4, 2023 20:03
e1f192a
…ge of protocol vs connection type
dthaler
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me now, thanks!
saxena-anurag
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Future work: These tests also found issue #3052 which is NOT resolved in this PR.
Testing
Documentation
N/A
Installation
N/A