Increase critical value threshold #3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Jowett <[email protected]>
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag,
shankarseal,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
shpalani
reviewed
Oct 25, 2023
| @@ -1094,7 +1094,7 @@ TEST_CASE("get_authentication_id", "[platform]") | |||
|
|
|||
| #define SEQUENCE_LENGTH 1024 * 128 | |||
| #define CHI_SQUARED_STATISTIC_THRESHOLD \ | |||
| 3.841 // Critical value for Chi-squared test with 2 degrees of freedom with significance level of 0.05. | |||
| 9.210 // Critical value for Chi-squared test with 2 degrees of freedom with significance level of 0.01. | |||
There was a problem hiding this comment.
For my understanding, how does the change in level help?
Was there a test failure/problem already encountered?
There was a problem hiding this comment.
The issue doesn't provide the Root Cause Analysis.
saxena-anurag
approved these changes
Oct 25, 2023
dv-msft
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2986
Description
Test of randomness for causes sporadic failures by being to strict.
Testing
CI/CD
Documentation
No.
Installation
No.