-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MSI testing in the CI/CD pipeline. #2953
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. See comment about expected file list + fix grammar nit.
To fix #1279, I think Install-eBPFComponents in install_ebpf.psm1 should be updated to install via the MSI rather than manually. The point is that the KM driver tests should be run after installing via the MSI. To fix #2422, I think the legacy ability to copy individual files should be removed from deploy-ebpf.ps1.in so all installation uses the MSI. |
This PR specifically adds testing to all the MSI actions. I updated the automatic closures, but I believe this PR has a very specific context, which should not be go outside testing exactly the MSI, and the MSI only. |
Closes #1037
Related #1279
Related #2422
Description
This PR adds full MSI testing for all the build configurations that are being released, i.e.
Build-x64 - Debug
andBuild-x64-native-only - NativeOnlyRelease
.The tests are directly performed in the corresponding build pipeline, as follows:
check_msi_installation_files_<build type>_<build configuration>.txt
):Testing
Local + CI/CD.
Documentation
Consequently to adding the automatic MSI testing in the CI/CD, the process in
ReleaseProcess.md
has been simplified.Installation
n.a.