Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up km_stress job labels. #2875

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

rectified95
Copy link
Collaborator

@rectified95 rectified95 commented Sep 21, 2023

Description

When adding the new WS2022 runners, I also renamed all the runner labels for consistency, but forgot to update the stress job to reflect that so it failed in the daily scheduled run.

Testing

Wait for nightly CI to spin.

Documentation

No change - docs already contain the new labels.

Installation

Is there any installer impact for this change?
No.

@Alan-Jowett
Copy link
Member

Suggestion:
Use matrix construct to simplify the ci/cd yaml. We have a lot of jobs that only differ by the environment they run on. It would make sense to define them once and use a matrix to expand them to both ws2019 and ws2022.

@dthaler dthaler added this pull request to the merge queue Sep 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 21, 2023
@Alan-Jowett Alan-Jowett added this pull request to the merge queue Sep 21, 2023
Merged via the queue into microsoft:main with commit e15e3b0 Sep 21, 2023
76 checks passed
@rectified95 rectified95 deleted the new_runners_followup branch September 21, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants