Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure gather and convert use same path for CSV #2870

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

Alan-Jowett
Copy link
Member

Description

This step gathers all the CSVs into a single location:

./gather_csv.sh ${{github.workspace}}/results_artifact ${{github.workspace}}/results/${{github.sha}}/results

This step converts them into a SQL statement:

python3 ./process_results.py --csv-directory ${{github.workspace}}/results --sql-script-file ${{github.workspace}}/results/upload.sql --commit_id ${{github.sha}} --platform "Windows 2019" --repository ${{github.repository}}

The problem is they are using two different locations.

Testing

CI/CD

Documentation

No.

Installation

No.

@Alan-Jowett Alan-Jowett added this pull request to the merge queue Sep 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #2870 (346ccb0) into main (47bafbf) will decrease coverage by 1.23%.
Report is 9 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2870      +/-   ##
==========================================
- Coverage   86.46%   85.23%   -1.23%     
==========================================
  Files         141      140       -1     
  Lines       26214    26293      +79     
==========================================
- Hits        22667    22412     -255     
- Misses       3547     3881     +334     
Files Changed Coverage Δ
ebpfcore/ebpf_drv.c 42.47% <ø> (+9.50%) ⬆️
libs/api_common/windows_platform_common.cpp 88.18% <100.00%> (-3.19%) ⬇️
libs/execution_context/ebpf_core.c 89.55% <100.00%> (-1.99%) ⬇️
libs/execution_context/ebpf_program.c 85.04% <100.00%> (-2.39%) ⬇️
libs/runtime/ebpf_epoch.c 93.28% <100.00%> (-2.66%) ⬇️
libs/runtime/ebpf_random.c 100.00% <100.00%> (ø)
libs/runtime/ebpf_state.c 86.56% <100.00%> (-4.48%) ⬇️
libs/shared/ebpf_shared_framework.h 100.00% <100.00%> (ø)
netebpfext/net_ebpf_ext_bind.c 70.89% <100.00%> (-4.37%) ⬇️
netebpfext/net_ebpf_ext_sock_ops.c 77.22% <100.00%> (-3.87%) ⬇️
... and 2 more

... and 39 files with indirect coverage changes

@rectified95
Copy link
Collaborator

Need to merge or rebase main for the new jobs to run. Just re-running wasn't enough.

@Alan-Jowett Alan-Jowett added this pull request to the merge queue Sep 21, 2023
Merged via the queue into microsoft:main with commit 9c981a4 Sep 21, 2023
75 of 76 checks passed
@Alan-Jowett Alan-Jowett deleted the fix_upload_script branch September 21, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants