Fastfail if constraints are violated #2864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Jowett <[email protected]>
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag,
shankarseal,
dv-msft,
delaramamiri,
gtrevi and
shpalani
as code owners
dthaler
reviewed
Sep 19, 2023
added 4 commits
September 20, 2023 09:41
Signed-off-by: Alan Jowett <[email protected]>
Signed-off-by: Alan Jowett <[email protected]>
Signed-off-by: Alan Jowett <[email protected]>
dthaler
reviewed
Sep 20, 2023
Codecov Report
@@ Coverage Diff @@
## main #2864 +/- ##
==========================================
- Coverage 86.45% 85.24% -1.21%
==========================================
Files 141 140 -1
Lines 26214 26293 +79
==========================================
- Hits 22663 22414 -249
- Misses 3551 3879 +328
|
dthaler
approved these changes
Sep 26, 2023
saxena-anurag
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2827
Description
Assert and fastfail if any of the key constraints of the epoch code are violated.
Testing
CI/CD
Documentation
No.
Installation
No.