Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add designated runner for perf jobs. #2845

Merged
merged 8 commits into from
Sep 15, 2023
Merged

Conversation

rectified95
Copy link
Collaborator

@rectified95 rectified95 commented Sep 12, 2023

Description

Adding dedicated runner for the km_performance job.

Note on labels: in reusable-test.yml the condition to check for self-hosted runners uses both the ebpf_cicd_tests and ebpf_cicd_perf labels, while every self-hosted runner gets the self-hosted label by default. However, the self-hosted label is useful/needed for runner migrations, so I chose not to use it; also we shouldn't have more than 2/3 different runner types (likely +1 for stress tests), so these expressions won't grow indefinitely.

Also, setting the job to only run in Release configuration. Since the tests don't work in Debug, we can halve the time the designated runner is occupied.

Testing

Successful run of the bpf_performance job forced to execute on commit push. Restoring original behavior of event-triggered runs.
[10:10:15] :: Timestamp,Test,Average Duration (ns),CPU 0 Duration (ns)
[10:10:15] :: 2023-09-13T17:10:15-0800,Baseline,17,17
[10:10:16] :: 2023-09-13T17:10:15-0800,bpf_get_prandom_u32,25,25
[10:10:16] :: 2023-09-13T17:10:16-0800,BPF_MAP_TYPE_ARRAY read,48,48
[10:10:17] :: 2023-09-13T17:10:16-0800,BPF_MAP_TYPE_ARRAY update,45,45
[...]
https://github.com/microsoft/ebpf-for-windows/actions/runs/6175281298/job/16762541899?pr=2845

Documentation

Will follow up with a more thorough update to the setup guide.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #2845 (e86101a) into main (01bc766) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2845   +/-   ##
=======================================
  Coverage   86.68%   86.69%           
=======================================
  Files         141      141           
  Lines       26182    26182           
=======================================
+ Hits        22697    22698    +1     
+ Misses       3485     3484    -1     

see 2 files with indirect coverage changes

@Alan-Jowett Alan-Jowett added this pull request to the merge queue Sep 15, 2023
@rectified95 rectified95 changed the title test perf runner Add designated runner for perf jobs. Sep 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 15, 2023
@Alan-Jowett Alan-Jowett added this pull request to the merge queue Sep 15, 2023
Merged via the queue into microsoft:main with commit c1ef869 Sep 15, 2023
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants