Add designated runner for perf jobs. #2845
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding dedicated runner for the
km_performance job
.Note on labels: in
reusable-test.yml
the condition to check for self-hosted runners uses both theebpf_cicd_tests
andebpf_cicd_perf
labels, while every self-hosted runner gets theself-hosted
label by default. However, theself-hosted
label is useful/needed for runner migrations, so I chose not to use it; also we shouldn't have more than 2/3 different runner types (likely +1 for stress tests), so these expressions won't grow indefinitely.Also, setting the job to only run in Release configuration. Since the tests don't work in Debug, we can halve the time the designated runner is occupied.
Testing
Successful run of the bpf_performance job forced to execute on commit push. Restoring original behavior of event-triggered runs.
[10:10:15] :: Timestamp,Test,Average Duration (ns),CPU 0 Duration (ns)
[10:10:15] :: 2023-09-13T17:10:15-0800,Baseline,17,17
[10:10:16] :: 2023-09-13T17:10:15-0800,bpf_get_prandom_u32,25,25
[10:10:16] :: 2023-09-13T17:10:16-0800,BPF_MAP_TYPE_ARRAY read,48,48
[10:10:17] :: 2023-09-13T17:10:16-0800,BPF_MAP_TYPE_ARRAY update,45,45
[...]
https://github.com/microsoft/ebpf-for-windows/actions/runs/6175281298/job/16762541899?pr=2845
Documentation
Will follow up with a more thorough update to the setup guide.