Sort programs to match bpf2c #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Jowett <[email protected]>
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag,
shankarseal,
dv-msft,
delaramamiri,
gtrevi and
shpalani
as code owners
saxena-anurag
previously approved these changes
Aug 23, 2023
|
bad_tail_call-native is failing. Switching to draft. |
Signed-off-by: Alan Jowett <[email protected]>
added 2 commits
August 23, 2023 09:18
Signed-off-by: Alan Jowett <[email protected]>
Signed-off-by: Alan Jowett <[email protected]>
dthaler
approved these changes
Aug 23, 2023
| // vector to match. If there are multiple programs per section, sort by program name. | ||
| std::sort(object.programs.begin(), object.programs.end(), [](const ebpf_program_t* a, const ebpf_program_t* b) { | ||
| int section_name_comparison = strcmp(a->section_name, b->section_name); | ||
| int program_name_comparison = strcmp(a->program_name, b->program_name); |
There was a problem hiding this comment.
nit: moving line 1757 into the else clause might be more efficient.
saxena-anurag
approved these changes
Aug 24, 2023
This was referenced Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2781
Description
The bpf2c tool populates the _programs array sorted by the section name for each program. This then defines the order in which program handles are returned from kernel to user mode. The function _ebpf_enumerate_native_sections returns programs in the order in which they occur in the PE file (which doesn't always match). The net result is that libbpf programs -> kernel handles sometimes don't match.
Testing
CI/CD
Documentation
No.
Installation
No.