Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ring buffer completion passes incorrect length #2704

Merged
merged 4 commits into from
Jul 31, 2023

Conversation

Alan-Jowett
Copy link
Member

Resolves: #2656

Description

  1. Ringbuffer async completion passes the wrong length for the output buffer.
  2. IO Manager mock doesn't correctly copy the buffers to and from kernel mode in the async path.
  3. Add instrumentation to test to catch duplicate records being returned.

Testing

Fixed existing tests to correctly catch this.

Documentation

No.

tests/end_to_end/test_helper.cpp Outdated Show resolved Hide resolved
tests/end_to_end/test_helper.cpp Outdated Show resolved Hide resolved
tests/end_to_end/test_helper.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #2704 (e9d5602) into main (78f826c) will increase coverage by 0.00%.
The diff coverage is 97.82%.

@@           Coverage Diff           @@
##             main    #2704   +/-   ##
=======================================
  Coverage   83.13%   83.13%           
=======================================
  Files         146      146           
  Lines       28070    28103   +33     
=======================================
+ Hits        23336    23364   +28     
- Misses       4734     4739    +5     
Files Changed Coverage Δ
tests/libs/common/common_tests.h 100.00% <ø> (ø)
tests/libs/common/common_tests.cpp 93.10% <90.90%> (-1.24%) ⬇️
libs/execution_context/ebpf_maps.c 90.44% <100.00%> (+<0.01%) ⬆️
tests/api_test/api_test.cpp 98.31% <100.00%> (+<0.01%) ⬆️
tests/end_to_end/test_helper.cpp 87.00% <100.00%> (+0.66%) ⬆️
tests/socket/socket_tests.cpp 98.88% <100.00%> (ø)

... and 2 files with indirect coverage changes

@dthaler dthaler enabled auto-merge July 28, 2023 23:27
@dthaler dthaler added this pull request to the merge queue Jul 31, 2023
Merged via the queue into microsoft:main with commit 1c87af4 Jul 31, 2023
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ring buffer completion does not indicate the consumer pointer correctly
4 participants