-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ring buffer completion passes incorrect length #2704
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthaler
reviewed
Jul 26, 2023
shankarseal
reviewed
Jul 26, 2023
Signed-off-by: Alan Jowett <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2704 +/- ##
=======================================
Coverage 83.13% 83.13%
=======================================
Files 146 146
Lines 28070 28103 +33
=======================================
+ Hits 23336 23364 +28
- Misses 4734 4739 +5
|
Signed-off-by: Alan Jowett <[email protected]>
Alan-Jowett
requested review from
poornagmsft,
saxena-anurag,
dv-msft,
delaramamiri,
gtrevi and
shpalani
as code owners
July 28, 2023 18:43
shankarseal
reviewed
Jul 28, 2023
dthaler
approved these changes
Jul 28, 2023
dv-msft
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2656
Description
Testing
Fixed existing tests to correctly catch this.
Documentation
No.