Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linux member names for IPV4_HEADER #2688

Merged
merged 1 commit into from
Jul 23, 2023
Merged

Conversation

hawkinsw
Copy link
Collaborator

Description

Fix #2637

Testing

No new tests are added.

Documentation

N/A

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #2688 (9186d69) into main (97fb3ae) will increase coverage by 1.95%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2688      +/-   ##
==========================================
+ Coverage   81.17%   83.12%   +1.95%     
==========================================
  Files         146      146              
  Lines       27763    28019     +256     
==========================================
+ Hits        22537    23292     +755     
+ Misses       5226     4727     -499     

see 55 files with indirect coverage changes

Alan-Jowett
Alan-Jowett previously approved these changes Jul 20, 2023
Add aliases for the members of the IPV4_HEADER struct so that it can be
used cross platform.

Signed-off-by: Will Hawkins <[email protected]>
@hawkinsw hawkinsw changed the title WIP: Add Linux field names for IPV4_HEADER Add Linux member names for IPV4_HEADER Jul 22, 2023
@hawkinsw hawkinsw requested a review from Alan-Jowett July 22, 2023 03:09
Copy link
Collaborator Author

@hawkinsw hawkinsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I addressed the comment!

include/net/ip.h Show resolved Hide resolved
include/net/ip.h Show resolved Hide resolved
@hawkinsw hawkinsw requested a review from dthaler July 23, 2023 03:42
@saxena-anurag saxena-anurag added this pull request to the merge queue Jul 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 23, 2023
@dthaler dthaler added this pull request to the merge queue Jul 23, 2023
Merged via the queue into microsoft:main with commit cc7c313 Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong iphdr and tcphdr mapping
4 participants