-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Linux member names for IPV4_HEADER #2688
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkinsw
requested review from
dthaler,
poornagmsft,
Alan-Jowett,
saxena-anurag,
shankarseal,
dv-msft,
delaramamiri,
gtrevi and
shpalani
as code owners
July 19, 2023 19:08
Codecov Report
@@ Coverage Diff @@
## main #2688 +/- ##
==========================================
+ Coverage 81.17% 83.12% +1.95%
==========================================
Files 146 146
Lines 27763 28019 +256
==========================================
+ Hits 22537 23292 +755
+ Misses 5226 4727 -499 |
Alan-Jowett
previously approved these changes
Jul 20, 2023
Add aliases for the members of the IPV4_HEADER struct so that it can be used cross platform. Signed-off-by: Will Hawkins <[email protected]>
hawkinsw
changed the title
WIP: Add Linux field names for IPV4_HEADER
Add Linux member names for IPV4_HEADER
Jul 22, 2023
dthaler
reviewed
Jul 22, 2023
hawkinsw
commented
Jul 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I addressed the comment!
dthaler
approved these changes
Jul 23, 2023
saxena-anurag
approved these changes
Jul 23, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #2637
Testing
No new tests are added.
Documentation
N/A