Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform trace logging #2685

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Uniform trace logging #2685

merged 4 commits into from
Jul 25, 2023

Conversation

gtrevi
Copy link
Collaborator

@gtrevi gtrevi commented Jul 19, 2023

Fixes #2651

Description

This PR:

  • Adds checking for the availability of the TraceLoggingProvider, where not previously implemented, accounting also for the contextual tracing level and keyword.
  • Refactors the macro functions' ordering in the source code.

Testing

CI/CD, local

Documentation

n.a.

@gtrevi gtrevi changed the title Fix logging Uniform trace logging Jul 19, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #2685 (5ca7bb2) into main (792d41c) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2685      +/-   ##
==========================================
- Coverage   83.12%   83.11%   -0.02%     
==========================================
  Files         146      146              
  Lines       28029    28029              
==========================================
- Hits        23299    23295       -4     
- Misses       4730     4734       +4     

see 2 files with indirect coverage changes

@gtrevi gtrevi added this pull request to the merge queue Jul 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 21, 2023
@saxena-anurag saxena-anurag added this pull request to the merge queue Jul 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 23, 2023
@gtrevi gtrevi added this pull request to the merge queue Jul 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 24, 2023
@gtrevi gtrevi added this pull request to the merge queue Jul 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 24, 2023
@gtrevi gtrevi added this pull request to the merge queue Jul 25, 2023
Merged via the queue into microsoft:main with commit d5e52ae Jul 25, 2023
68 checks passed
@gtrevi gtrevi deleted the gtrevi/fix-log-entry branch July 25, 2023 00:18
@gtrevi gtrevi restored the gtrevi/fix-log-entry branch August 7, 2023 22:58
@gtrevi gtrevi deleted the gtrevi/fix-log-entry branch November 8, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent trace logging
3 participants