Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bpf2c from redist-package #2684

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

shpalani
Copy link
Collaborator

@shpalani shpalani commented Jul 18, 2023

Description

Removed bpf2c.exe/.pdb from the redist-package:

  1. tools/redist-package/ebpf-for-windows-redist.nuspec.in
  2. tools/redist-package/redist-package.vcxproj

Testing

_Do any existing tests cover this change? N/A
Are new tests needed? No

Manual Testing: Check if the bpf2c.exe and bpf2c.pdb does not exist.

PS C:\Users\...\Downloads\ebpf-for-windows - NuGet Redist package (Build-x64_Release)\eBPF-for-Windows-Redist.0.9.0\package\bin> dir


    Directory: C:\Users\...\Downloads\ebpf-for-windows - NuGet Redist package
    (Build-x64_Release)\eBPF-for-Windows-Redist.0.9.0\package\bin


Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d-----         7/18/2023   3:18 PM                drivers
-a----         7/18/2023   3:18 PM          77312 bpftool.exe
-a----         7/18/2023   3:18 PM         913408 bpftool.pdb
-a----         7/18/2023   3:18 PM         327504 concrt140.dll
-a----         7/18/2023   3:18 PM        1539584 EbpfApi.dll
-a----         7/18/2023   3:18 PM        9605120 EbpfApi.pdb
-a----         7/18/2023   3:18 PM          81920 ebpfnetsh.dll
-a----         7/18/2023   3:18 PM        1511424 ebpfnetsh.pdb
-a----         7/18/2023   3:18 PM          12288 ebpf_tracing.cmd
-a----         7/18/2023   3:18 PM           2444 ebpf_tracing_periodic_task.xml
-a----         7/18/2023   3:18 PM           2096 ebpf_tracing_startup_task.xml
-a----         7/18/2023   3:18 PM         579920 msvcp140.dll
-a----         7/18/2023   3:18 PM          35664 msvcp140_1.dll
-a----         7/18/2023   3:18 PM         197488 msvcp140_2.dll
-a----         7/18/2023   3:18 PM          50032 msvcp140_atomic_wait.dll
-a----         7/18/2023   3:18 PM          31600 msvcp140_codecvt_ids.dll
-a----         7/18/2023   3:18 PM           6152 Open Notebook.onetoc2
-a----         7/18/2023   3:18 PM         345928 vccorlib140.dll
-a----         7/18/2023   3:18 PM         109392 vcruntime140.dll
-a----         7/18/2023   3:18 PM          49520 vcruntime140_1.dll

Documentation

_Is there any documentation impact for this change? No

Note: Adding my id to the default code reviewer list.

@shpalani shpalani marked this pull request as ready for review July 18, 2023 20:34
@shpalani shpalani linked an issue Jul 18, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #2684 (713c8fe) into main (792d41c) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2684      +/-   ##
==========================================
- Coverage   83.12%   83.11%   -0.02%     
==========================================
  Files         146      146              
  Lines       28029    28029              
==========================================
- Hits        23299    23295       -4     
- Misses       4730     4734       +4     

see 2 files with indirect coverage changes

@shpalani shpalani added this pull request to the merge queue Jul 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 19, 2023
@shpalani shpalani added this pull request to the merge queue Jul 19, 2023
Merged via the queue into microsoft:main with commit 1b63f75 Jul 19, 2023
68 checks passed
@shpalani shpalani deleted the shpalan/remove-bpf2c branch July 19, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove bpf2c.exe from the redist-package project.
3 participants