Convert usersim to a DLL #2683
Merged
Convert usersim to a DLL #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
PR microsoft#1192 updated the vcxproj file but not the corresponding CMakeLists.txt file for export_program_info Signed-off-by: Dave Thaler <[email protected]>
dthaler
requested review from
poornagmsft,
Alan-Jowett,
saxena-anurag,
shankarseal,
dv-msft,
delaramamiri and
gtrevi
as code owners
Alan-Jowett
previously approved these changes
Jul 18, 2023
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2683 +/- ##
==========================================
- Coverage 83.12% 83.11% -0.02%
==========================================
Files 146 146
Lines 28029 28070 +41
==========================================
+ Hits 23299 23329 +30
- Misses 4730 4741 +11
|
Signed-off-by: Dave Thaler <[email protected]>
| @@ -450,9 +450,6 @@ TEST_CASE("epoch_test_stale_items", "[platform]") | |||
| return; | |||
| } | |||
|
|
|||
| KIRQL old_irql; | |||
| KeRaiseIrql(DISPATCH_LEVEL, &old_irql); | |||
There was a problem hiding this comment.
nit: why did we remove this?
There was a problem hiding this comment.
It's explained in the PR description.
saxena-anurag
previously approved these changes
Jul 27, 2023
Signed-off-by: Dave Thaler <[email protected]>
Alan-Jowett
approved these changes
Jul 27, 2023
saxena-anurag
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DISPATCH_LEVELor it can block execution of one of the two test threads if they are affinitized to the same processor as the main test thread.single_instance_hook_ttest class to not throw exceptions in unit tests, but rather allow usingREQUIRE()so catch2 can correctly deal with fault injectionFixes #2586
Testing
Covered by existing tests
Documentation
No impact