Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay-load rarely used binaries #2681

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Conversation

Alan-Jowett
Copy link
Member

Description

Delay load DLLs that have rarely used functions.

Testing

CI/CD

Documentation

No.

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #2681 (d002151) into main (792d41c) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2681      +/-   ##
==========================================
- Coverage   83.12%   83.11%   -0.02%     
==========================================
  Files         146      146              
  Lines       28029    28029              
==========================================
- Hits        23299    23296       -3     
- Misses       4730     4733       +3     

see 3 files with indirect coverage changes

dthaler
dthaler previously approved these changes Jul 18, 2023
Copy link
Collaborator

@dthaler dthaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR updates the vcxproj file but what about the CMakeLists.txt used by the cmake build?

@dthaler dthaler dismissed their stale review July 18, 2023 03:56

Added question in a comment

@dthaler dthaler added this pull request to the merge queue Jul 18, 2023
Merged via the queue into microsoft:main with commit 0c64dde Jul 18, 2023
68 checks passed
Alan-Jowett added a commit to Alan-Jowett/ebpf-for-windows that referenced this pull request Jul 20, 2023
* Delay-load rarely used binaries

Signed-off-by: Alan Jowett <[email protected]>

* PR feedback

Signed-off-by: Alan Jowett <[email protected]>

---------

Signed-off-by: Alan Jowett <[email protected]>
Co-authored-by: Alan Jowett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants