Reduce code pages touched during ebpf_api_initiate #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag,
shankarseal,
dv-msft,
delaramamiri and
gtrevi
as code owners
dthaler
previously approved these changes
Jul 17, 2023
dthaler
previously approved these changes
Jul 17, 2023
Codecov Report
@@ Coverage Diff @@
## main #2678 +/- ##
==========================================
- Coverage 87.18% 83.10% -4.08%
==========================================
Files 139 146 +7
Lines 26542 28040 +1498
==========================================
+ Hits 23141 23304 +163
- Misses 3401 4736 +1335
|
dv-msft
previously approved these changes
Jul 17, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
shankarseal
reviewed
Jul 19, 2023
dthaler
previously approved these changes
Jul 19, 2023
added 2 commits
July 24, 2023 10:15
Signed-off-by: Alan Jowett <[email protected]>
Signed-off-by: Alan Jowett <[email protected]>
Alan-Jowett
force-pushed
the
ebpf_api_initiate_minimization
branch
from
40b6b82
to
84d0ad7
Compare
dthaler
approved these changes
Jul 25, 2023
dv-msft
approved these changes
Jul 31, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Eliminate 5 pages from ebpf_api_initiate.
Testing
CI/CD + WPR + WPA comparative analysis (shows pages no longer being touched).
Documentation
No.
Notes:
The API load_ebpf_provider_data is best effort, so removing the result.