Always end tool install with where command #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Jowett <[email protected]>
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag,
shankarseal,
dv-msft,
delaramamiri and
gtrevi
as code owners
dthaler
approved these changes
Jul 11, 2023
| @@ -123,6 +123,7 @@ jobs: | |||
| run: | | |||
| choco install -y llvm --version 11.0.1 --allow-downgrade | |||
| echo "C:\Program Files\LLVM\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append | |||
| where clang.exe | |||
There was a problem hiding this comment.
nit: does this also help fail the CICD step if the installation of the tool fails?
There was a problem hiding this comment.
Yes, the exit code of the last command determines if the task succeeds or fails. The issue is that the choco install fails, but the next line (the "echo") succeeds, so the task wasn't being failed. By adding an explicit check for the binary, this will fail if the exe isn't present.
There was a problem hiding this comment.
Please add that fact to the PR description in github. Thanks!
saxena-anurag
approved these changes
Jul 11, 2023
delaramamiri
approved these changes
Jul 11, 2023
Codecov Report
@@ Coverage Diff @@
## main #2668 +/- ##
==========================================
- Coverage 81.19% 81.17% -0.03%
==========================================
Files 147 147
Lines 27784 27784
==========================================
- Hits 22559 22553 -6
- Misses 5225 5231 +6 |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tool install commands should validate that the tool is installed and is present in the path via the where command.
Testing
CI/CD
Documentation
No.