Fix build failures with latest MSVC (main)

[saxena-anurag]

Description

Looks like the MSVC version has again changed from 14.35.32215 to 14.36.32532 and broke the build for the main branch. This PR fixes the build failures and contains the following changes:

1. Use vcvars64 and set the environment variables for VCToolsInstallDir and VCToolsVersion, so that we dont hardcode path in the yml.
2. Fixes for new analysis failures flagged by new MSVC version.

Testing

Existing CICD

Documentation

NA

[dthaler]

can you use the VCToolsInstallDir environment variable to automatically get the right path and not have to change it when github updates the msvc version?

[gtrevi]

@dthaler
@saxena-anurag

Yes, it can be done, but still the VS version and product type would have to be hard-coded (i.e. "2022", and "Enterprise"/"Community"/etc.), if the current console does not have the VC environment variables:

# Generate the Visual Studio environment variables (if not already done)
> call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"

# Parse the output string (or just use the variable)
> echo %VCToolsInstallDir%
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.36.32532\

Something like

call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
copy %VCToolsInstallDir%bin\Hostx64\x64\clang*

[dthaler]

github preinstalls Visual Studio so that variable should always be set I think

[gtrevi]

The VS environment variables are not installed as System defaults, i.e. that's why VS offers a "VS Command Prompt", which basically just runs that .bat script.

[saxena-anurag]

I did a quick test and %VCToolsInstallDir% is not available by default in the runner.

[dthaler]

Maybe use the VSVARS32 script to get the variable set to save to github environment variables then for future steps.

• https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-environment-variable

[saxena-anurag]

Updated PR to use environment variable. Also updated the cache hash to use the VS tool version.

[codecov]

Codecov Report

Merging #2598 (e833fac) into main (3e77670) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2598      +/-   ##
==========================================
+ Coverage   83.91%   83.96%   +0.05%     
==========================================
  Files         157      157              
  Lines       29173    29177       +4     
==========================================
+ Hits        24480    24499      +19     
+ Misses       4693     4678      -15     

Impacted Files	Coverage Δ
...ution_context/unit/execution_context_unit_test.cpp	98.88% <ø> (ø)
tests/end_to_end/test_helper.cpp	86.82% <ø> (ø)
tests/libs/util/socket_helper.cpp	49.52% <100.00%> (+0.15%)	⬆️

... and 11 files with indirect coverage changes