Move usersim code into a separate repo #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthaler
requested review from
poornagmsft,
Alan-Jowett,
saxena-anurag,
shankarseal,
dv-msft,
delaramamiri and
gtrevi
as code owners
dthaler
changed the title
dthaler
force-pushed
the
usersim
branch
9 times, most recently
from
ac0479e
to
0f65744
Compare
Signed-off-by: Dave Thaler <[email protected]>
Per Anurag: the code was added earlier to execute the 2 paths in native module, and it is not needed anmore IIRC, as the "DISPATCH" code has been removed now from the native module Signed-off-by: Dave Thaler <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2596 +/- ##
==========================================
- Coverage 83.78% 81.10% -2.69%
==========================================
Files 157 146 -11
Lines 29177 27605 -1572
==========================================
- Hits 24447 22389 -2058
- Misses 4730 5216 +486
|
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
dthaler
changed the title
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
saxena-anurag
approved these changes
Jun 26, 2023
| @@ -76,6 +77,9 @@ _netebpf_ext_helper::_netebpf_ext_helper( | |||
| nmr_hook_client_handle = std::make_unique<nmr_client_registration_t>(&hook_client, client_context); | |||
| nmr_hook_client_handle_initialized = true; | |||
| } | |||
|
|
|||
| _fwp_engine::get()->set_sublayer_guids( | |||
There was a problem hiding this comment.
nit: I think the _fwp_engine::test_* functions in usersim/src/fwp_um.cpp should be part of this repository.
There was a problem hiding this comment.
I will deal with that in the next PR in the series. But offhand, I probably disagree. Anything that allows a unit test to exercise WFP apis in a way that isn't ebpf specific would help any WFP client driver developer.
There was a problem hiding this comment.
Yes this is not blocking for this PR (I have already approved the PR).
Alan-Jowett
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses a portion of #2586
This step is usable on its own, but additional simplifications will come in a future PR.
Testing
Existing tests are updated.
Documentation
No impact.